fix: Address critical issues from PR review

Fix 4 critical issues identified in code review:

**Error Handling Improvements:**
- Replace bare except blocks with specific exception handlers
- Add logging for TimeoutException and ConnectError
- Prevent silent failures in season loading
- Remove misleading "0 episodes" on error

**Robustness Fixes:**
- Add safe None handling in title comparison (main.py)
  Prevents crash when title is None
- Add URL validation before encodeURIComponent (anime.js)
  Prevents crash when anime.url is undefined
- Fix unreachable code in retry logic (recommendations.py)
  Preserve retry context in exception messages

**Changes:**
- animesama.py: Specific exception handling with print statements
- main.py: Safe None handling with (x.get('title') or '')
- anime.js: URL validation before encoding
- recommendations.py: Better exception messages with retry context

All fixes tested and working correctly.

Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>

app/downloaders/anime_sites/animesama.py

@@ -943,8 +943,13 @@ class AnimeSamaDownloader(BaseAnimeSite):
                                 'url': season_url,
                                 'episode_count': None  # Will fetch later if needed
                             }
-                    except Exception:
+                    except httpx.TimeoutException:
+                        # Silent skip - season likely doesn't exist
                         pass
+                    except httpx.ConnectError as e:
+                        print(f"[ANIME-SAMA] Connection error checking season {season_num}: {e}")
+                    except Exception as e:
+                        print(f"[ANIME-SAMA] Unexpected error checking season {season_num}: {e}")
                     return None
 
                 # Check seasons 1-10 in parallel
@@ -970,8 +975,11 @@ class AnimeSamaDownloader(BaseAnimeSite):
                             # Skip seasons with no episodes
                             print(f"[ANIME-SAMA] Skipping Saison {season_info['season']} (no episodes)")
                             return None
-                    except Exception:
+                    except httpx.TimeoutException:
-                        return None
+                        print(f"[ANIME-SAMA] Timeout fetching episodes for season {season_info['season']}")
+                    except Exception as e:
+                        print(f"[ANIME-SAMA] Error fetching episodes for season {season_info['season']}: {e}")
+                    return None
 
                 if seasons:
                     episode_tasks = [fetch_episode_count(s) for s in seasons]
@@ -999,19 +1007,20 @@ class AnimeSamaDownloader(BaseAnimeSite):
                             # Get episode count for this season
                             try:
                                 episodes = await self.get_episodes(season_url)
-                                seasons.append({
+                                episode_count = len(episodes) if episodes else 0
-                                    'season': season_num,
+                                if episode_count > 0:
-                                    'title': f'Saison {season_num}',
+                                    seasons.append({
-                                    'url': season_url,
+                                        'season': season_num,
-                                    'episode_count': len(episodes) if episodes else 0
+                                        'title': f'Saison {season_num}',
-                                })
+                                        'url': season_url,
-                            except Exception:
+                                        'episode_count': episode_count
-                                seasons.append({
+                                    })
-                                    'season': season_num,
+                                else:
-                                    'title': f'Saison {season_num}',
+                                    print(f"[ANIME-SAMA] Skipping season {season_num} (no episodes)")
-                                    'url': season_url,
+                            except httpx.TimeoutException:
-                                    'episode_count': 0
+                                print(f"[ANIME-SAMA] Timeout fetching episodes for season {season_num}")
-                                })
+                            except Exception as e:
+                                print(f"[ANIME-SAMA] Error fetching episodes for season {season_num}: {e}")
 
             # Sort by season number
             seasons.sort(key=lambda x: x['season'])

app/recommendations.py

@@ -46,6 +46,7 @@ class AnimeReleasesFetcher:
                         continue
                     else:
                         logger.error("Jikan API rate limit exceeded after all retries")
+                        raise Exception(f"Jikan API rate limit exceeded after {max_retries} retries")
 
                 return response
 
@@ -55,9 +56,10 @@ class AnimeReleasesFetcher:
                     logger.warning(f"Request timeout, retrying in {delay}s... (attempt {attempt + 1}/{max_retries})")
                     await asyncio.sleep(delay)
                 else:
-                    raise
+                    raise Exception(f"Request timeout after {max_retries} retries") from e
-
+            except Exception as e:
-        raise Exception("Max retries exceeded for Jikan API request")
+                # For any other exception, don't retry
+                raise
 
     async def _get_cached(self, key: str, fetcher):
         """Get cached result or fetch new data"""

main.py

@@ -524,7 +524,7 @@ async def search_anime_unified(q: str, lang: str = "vostfr", include_metadata: b
     for provider_id in results:
         results[provider_id].sort(key=lambda x: (
             -x.get('_relevance_boost', 0),  # Exact matches first
-            x.get('title', '').lower().find(q.lower())  # Then by position of match
+            (x.get('title') or '').lower().find(q.lower())  # Then by position of match
         ))
         # Remove temporary boost field
         for item in results[provider_id]:

static/js/anime.js

@@ -38,7 +38,9 @@ async function displaySearchResults(data, lang) {
                 // Stagger requests: 500ms delay between each anime
                 setTimeout(() => {
                     // Try to load seasons first (for Anime-Sama)
-                    loadSeasonsForAnime(providerId, encodeURIComponent(anime.url));
+                    if (anime.url) {
+                        loadSeasonsForAnime(providerId, encodeURIComponent(anime.url));
+                    }
                 }, 500 * index);
                 delayCounter++;
             });