From dac57d3c63375dabfc293fec9b18077f27933182 Mon Sep 17 00:00:00 2001
From: feldenr <135638674+feldenr@users.noreply.github.com>
Date: Tue, 16 Jun 2026 21:41:25 +0200
Subject: [PATCH] fix: synchronize ore generation with latitude climate tags

The ore biome modifiers still referenced the legacy climate tags
(cold_biomes / tempered_biomes / hot_biomes) which were out of sync with the
new latitude system (latitude_cold_surface / _temperate_surface / _hot_surface).
As a result ores did not spawn where the player would expect them, several BOP
biomes got no ores at all, and surface ores leaked into oceans.

All three climate modifiers now point at the latitude surface tags, so ore
distribution follows the climate exactly. Because the latitude tags exclude
oceans, the fix also removes iron/coal generation under oceans.

Result (verified by coverage analysis):
  North (cold/frozen)      -> Lapis + Diamond          (27 biomes, +16 BOP)
  Equator (temperate/spawn)-> Iron + Coal             (31 biomes, +21 BOP)
  South (hot)              -> Gold + Copper + Redstone(22 biomes, +11 BOP)
  0 orphan surface biomes; no ocean surface ores. GameTest still green.
---
 .../neoforge/biome_modifier/add_cold_biomes_ores.json           | 2 +-
 .../neoforge/biome_modifier/add_hot_biomes_ores.json            | 2 +-
 .../neoforge/biome_modifier/add_tempered_biomes_ores.json       | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/main/resources/data/custom_ore_gen/neoforge/biome_modifier/add_cold_biomes_ores.json b/src/main/resources/data/custom_ore_gen/neoforge/biome_modifier/add_cold_biomes_ores.json
index 91473c3e..5d40b420 100644
--- a/src/main/resources/data/custom_ore_gen/neoforge/biome_modifier/add_cold_biomes_ores.json
+++ b/src/main/resources/data/custom_ore_gen/neoforge/biome_modifier/add_cold_biomes_ores.json
@@ -1,6 +1,6 @@
 {
     "type": "neoforge:add_features",
-    "biomes": "#custom_ore_gen:cold_biomes",
+    "biomes": "#custom_ore_gen:latitude_cold_surface",
     "features": [
         "custom_ore_gen:lapisore",
         "custom_ore_gen:deepslatelapisore",
diff --git a/src/main/resources/data/custom_ore_gen/neoforge/biome_modifier/add_hot_biomes_ores.json b/src/main/resources/data/custom_ore_gen/neoforge/biome_modifier/add_hot_biomes_ores.json
index c0df5e8b..78dd11f4 100644
--- a/src/main/resources/data/custom_ore_gen/neoforge/biome_modifier/add_hot_biomes_ores.json
+++ b/src/main/resources/data/custom_ore_gen/neoforge/biome_modifier/add_hot_biomes_ores.json
@@ -1,6 +1,6 @@
 {
     "type": "neoforge:add_features",
-    "biomes": "#custom_ore_gen:hot_biomes",
+    "biomes": "#custom_ore_gen:latitude_hot_surface",
     "features": [
         "custom_ore_gen:puregoldenore",
         "custom_ore_gen:deepslatepuregoldenore",
diff --git a/src/main/resources/data/custom_ore_gen/neoforge/biome_modifier/add_tempered_biomes_ores.json b/src/main/resources/data/custom_ore_gen/neoforge/biome_modifier/add_tempered_biomes_ores.json
index 2693036a..420649f6 100644
--- a/src/main/resources/data/custom_ore_gen/neoforge/biome_modifier/add_tempered_biomes_ores.json
+++ b/src/main/resources/data/custom_ore_gen/neoforge/biome_modifier/add_tempered_biomes_ores.json
@@ -1,6 +1,6 @@
 {
     "type": "neoforge:add_features",
-    "biomes": "#custom_ore_gen:tempered_biomes",
+    "biomes": "#custom_ore_gen:latitude_temperate_surface",
     "features": [
         "custom_ore_gen:ironore",
         "custom_ore_gen:deepslateironore",